Examples of errors detected by the V684 diagnostic

V684. A value of variable is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'.


V8 JavaScript Engine

V684 A value of the variable '* (cases - 1)' is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'. ucol.cpp 4941


U_CFUNC int32_t U_CALLCONV
ucol_calcSortKey(....)
{
  ....
  if((caseBits & 0xC0) == 0) {
    *(cases-1) |= 1 << (--caseShift);
  } else {
    *(cases-1) |= 0 << (--caseShift);
  ....
}

Similar errors can be found in some other places:

  • V684 A value of the variable '* (cases - 1)' is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'. ucol.cpp 4948
  • V684 A value of the variable 'caseByte' is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'. ucol.cpp 6201
  • V684 A value of the variable 'caseByte' is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'. ucol.cpp 6212


Bugs Found

Checked Projects
409
Collected Errors
14 072
This website uses cookies and other technology to provide you a more personalized experience. By continuing the view of our web-pages you accept the terms of using these files. If you don't want your personal data to be processed, please, leave this site. Learn More →
Accept